Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theory and Math Behind RPG Quadrotor Control : Possible mistake #89

Open
YacineBenameur opened this issue May 21, 2019 · 2 comments
Open

Comments

@YacineBenameur
Copy link

Please correct me if I'm wrong, but I think i spotted a mistake in your paer : Theory and Math Behind RPG Quadrotor Control.

The angular velocity omegaWB is equal to [p,q,r] in the body frame and not in the world frame as it appears to be stated in many equations (i.e equations (167) and (168)).

@foehnx
Copy link
Contributor

foehnx commented Jun 3, 2019

Dear @YacineBenameur

You are correct. In fact I think that according to the euqations, all used representations of the bodyrate should be in body frame but are wrongly denoted as in world frame.
@mfaessle could you confirm this?

@mfaessle
Copy link
Contributor

mfaessle commented Jun 5, 2019

@foehnph I confirm there are some mistakes with the indexes and I agree that they are wrongly denoted as in world frame. There might be more of these little inconsistencies and mistakes since this document was put together from many documents and papers we wrote over the years.
@YacineBenameur I'd be happy to review a pull request with fixes if you are motivated ;) Otherwise it might happen that I look into this in a very motivated hour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants