Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allocate message buffer properly, fix memory leaks #47

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Allocate message buffer properly, fix memory leaks #47

merged 1 commit into from
Jan 23, 2025

Conversation

v-kiniv
Copy link
Owner

@v-kiniv v-kiniv commented Jan 22, 2025

No description provided.

@v-kiniv v-kiniv mentioned this pull request Jan 22, 2025
Closed
@martinfri
Copy link
Contributor

It looks good! I have tested it a bit. However I have not tested that it solves #27

@martinfri
Copy link
Contributor

I tested with a weird custom service:

ros2 interface show tutorial_interfaces/srv/StringArrayCheck
# Request: an array of strings
string[] strings
tutorial_interfaces/Nested[] nested_strings
	string[] nested_strings
---
# Response: a boolean
bool success

This did work great, i think you can close #27 aswell

@v-kiniv
Copy link
Owner Author

v-kiniv commented Jan 23, 2025

Great, thanks for also testing nested strings case

@v-kiniv v-kiniv merged commit 4898d98 into main Jan 23, 2025
@martinfri
Copy link
Contributor

Can you merge the fix with humble as well? thx

@v-kiniv
Copy link
Owner Author

v-kiniv commented Jan 23, 2025

Can you merge the fix with humble as well? thx

Yes, I will backport it to other branches soon

v-kiniv added a commit that referenced this pull request Jan 23, 2025
@v-kiniv
Backport #47: Allocate message buffer properly, fix memory leaks
2086030
@v-kiniv v-kiniv deleted the fix/memory-leaks branch January 23, 2025 18:45
v-kiniv added a commit that referenced this pull request Jan 23, 2025
@v-kiniv
Backport #47: Allocate message buffer properly, fix memory leaks
0637fe4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v-kiniv @martinfri