Wait forever for fatal errors #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerShor
requested changes
Jan 14, 2025
pkg/common/helper.go
Outdated
Comment on lines
195
to
196
| } | ||
| func errorMatches(err error, substrings []string) bool { |
Comment on lines
129
to
130
| &c.getShardLocationBackoff, func(attempt int) (bool, error, int) { | ||
| c.currentShardLocation, err = c.getCurrentShardLocation(c.shardID) |
There was a problem hiding this comment.
Suggested change
| &c.getShardLocationBackoff, func(attempt int) (bool, error, int) { | |
| c.currentShardLocation, err = c.getCurrentShardLocation(c.shardID) | |
| &c.getShardLocationBackoff, | |
| func(attempt int) (bool, error, int) { | |
| c.currentShardLocation, err = c.getCurrentShardLocation(c.shardID) |
pkg/common/helper.go
Outdated
|
|
||
| func EngineErrorIsFatal(err error) bool { | ||
| var fatalEngineErrorsPartialMatch = []string{ | ||
| "Failed to fetch record batches", |
There was a problem hiding this comment.
This is not the error from v3io, this is a log the this client prints later.
As the ticket says, you want to retry on:
lookup v3io-webapi: i/o timeout
TomerShor
reviewed
Jan 15, 2025
| // if the error is fatal and requires external resolution, | ||
| // we don't want to fail; instead, we will inform the user via a log | ||
| if common.EngineErrorIsFatal(err) { | ||
| // although RetryFunc already logs the error, it logs it as a warning |
There was a problem hiding this comment.
It actually doesn't log the error?
There was a problem hiding this comment.
Lines 71 to 81 in 0d34f11
There was a problem hiding this comment.
This warning is for a ctx.Error, like if an external error happened.
In your case you check the error returned from getCurrentShardLocation, which isn't handled by the retry func.
There was a problem hiding this comment.
@TomerShor right 🤦
i'll remove comment
TomerShor
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira - https://iguazio.atlassian.net/browse/NUC-340