Skip to content

Commit

Permalink
breaking: Drop support for Node 16
Browse files Browse the repository at this point in the history
  • Loading branch information
vHeemstra committed Feb 14, 2024
1 parent d609d9a commit 86c8441
Show file tree
Hide file tree
Showing 6 changed files with 31 additions and 29 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/manual_bump_version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@ jobs:
- name: Set up NASM (for imagemin binary builds)
uses: ilammy/setup-nasm@v1
- name: Check out repository
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0
token: ${{ secrets.GH_PERSONAL_ACCESS_TOKEN }}

- name: Install Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x
registry-url: https://registry.npmjs.org/

- name: Set Git user
Expand All @@ -53,7 +53,7 @@ jobs:
run: npm run bump:patch

- name: Archive npm failure logs
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: failure()
with:
name: npm-logs
Expand Down
12 changes: 7 additions & 5 deletions .github/workflows/manual_run_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,16 @@ on:
node_versions:
description: 'Select Node versions'
required: true
default: '["16.x", "18.x"]'
default: '["18.x", "20.x"]'
type: choice
options:
# - '["14.x"]'
- '["16.x"]'
# - '["16.x"]'
- '["18.x"]'
- '["16.x", "18.x"]'
- '["20.x"]'
# - '["14.x", "16.x", "18.x"]'
# - '["16.x", "18.x"]'
- '["18.x", "20.x"]'
os_version:
description: 'Select OS'
required: true
Expand Down Expand Up @@ -41,9 +43,9 @@ jobs:
- name: Set up NASM (for imagemin binary builds)
uses: ilammy/setup-nasm@v1
- name: Check out repository
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Install Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm ci
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/publish_on_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node-version: [16.x, 18.x]
node-version: [18.x, 20.x]
runs-on: ${{ matrix.os }}
steps:
- name: Set up NASM (for imagemin binary builds)
uses: ilammy/setup-nasm@v1
- name: Check out repository
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Install Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
# cache: 'npm'
Expand All @@ -36,11 +36,11 @@ jobs:
- name: Set up NASM (for imagemin binary builds)
uses: ilammy/setup-nasm@v1
- name: Check out repository
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Install Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x
# cache: 'npm'
registry-url: 'https://registry.npmjs.org'
- run: npm ci
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/release_on_version_push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
node-version: [16.x, 18.x]
node-version: [18.x, 20.x]
runs-on: ${{ matrix.os }}
defaults:
run:
Expand All @@ -21,9 +21,9 @@ jobs:
- name: Set up NASM (for imagemin binary builds)
uses: ilammy/setup-nasm@v1
- name: Check out repository
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Install Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm ci
Expand All @@ -42,7 +42,7 @@ jobs:
s=':white_check_mark: '"Node ${{ matrix.node-version }}"
echo "$s" > ${{ env.FILENAME_TXT }}
- name: Upload artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ env.FILENAME }}
path: ${{ env.FILENAME_TXT }}
Expand All @@ -61,14 +61,14 @@ jobs:
uses: ilammy/setup-nasm@v1

- name: Check out repository
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Install Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x
registry-url: https://registry.npmjs.org/

- name: Set Git user
Expand All @@ -92,7 +92,7 @@ jobs:
# echo $RELEASE_VERSION
# echo ${{ env.RELEASE_VERSION }}
- name: Download artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
# NOTE: if all artifacts are downloaded,
# they will each put in their own folder.

Expand All @@ -102,7 +102,7 @@ jobs:
echo "$s" > matrix-all.txt
- name: Upload merged artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: matrix-all
path: matrix-all.txt
Expand All @@ -123,7 +123,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GH_PERSONAL_ACCESS_TOKEN }}
steps:
- name: Clean up artifacts
uses: geekyeggo/delete-artifact@v2
uses: geekyeggo/delete-artifact@v4
with:
name: |
matrix-*
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test_on_pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [16.x, 18.x]
node-version: [18.x, 20.x]
steps:
- name: Set up NASM (for imagemin binary builds)
uses: ilammy/setup-nasm@v1
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
# cache: 'npm'
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.2.1",
"private": true,
"engines": {
"node": ">=16.0.0"
"node": ">=18.0.0"
},
"type": "module",
"homepage": "https://github.com/vheemstra/vite-plugin-imagemin#readme",
Expand Down

0 comments on commit 86c8441

Please sign in to comment.