docs: document menu-bar reverse-collapse #3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Language unchecked
| Items that don't fit into the current width of the menu bar collapse into an overflow menu at the end: | ||
| Items that don't fit into the current width of the menu bar collapse into an overflow menu at the end. | ||
|
|
||
| By default, collapsed items are removed from the end of the menu bar, but the component can be configured to remove items from the start instead. |
There was a problem hiding this comment.
Should it mention the API name?
There was a problem hiding this comment.
We don't usually mention API specifics in the documentation because the same documentation is shared by Flow, Lit, and React users while the API is different for all these component types. The component type-specific API can usually be discovered in the example source. In this case, there is no live example, so it's only available in the API documentation.
There was a problem hiding this comment.
Right. Do we also need to add the since... tag here?
rolfsmeds
approved these changes
Feb 13, 2024
DiegoCardoso
approved these changes
Feb 14, 2024
platosha
pushed a commit
that referenced
this pull request
Feb 22, 2024
russelljtdyer
added a commit
that referenced
this pull request
Mar 5, 2024
* Add Flow React adapter integration guide * docs: document menu-bar reverse-collapse (#3188) * chore: replace `@vaadin/hilla-core` with `@vaadin/hilla-frontend` (#3178) * chore: replace @vaadin/hilla-frontend with @vaadin/hilla-frontend Follow-up for vaadin/hilla#2052 Fixes #3177 * upgrade to alpha4 --------- Co-authored-by: Anton Platonov <[email protected]> * chore: update vaadin.version and springboot (#3202) * split Java example into more steps * chore: update to 24.4 alpha4 * First full pass at editing. * Second full pass at editing. --------- Co-authored-by: Tomi Virkki <[email protected]> Co-authored-by: Soroosh Taefi <[email protected]> Co-authored-by: Zhe Sun <[email protected]> Co-authored-by: Mikhail Shabarov <[email protected]> Co-authored-by: Russell J.T. Dyer <[email protected]>
russelljtdyer
added
Language checked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of vaadin/platform#5018