Use setItemsPageable in data binding docs #4148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Language unchecked
russelljtdyer
added
Language checking
russelljtdyer
added
Language checked
mshabarov
reviewed
Mar 10, 2025
Comment on lines
156
to
161
| If you Spring service requires additional parameters, you can use the longer version | ||
|
|
||
| [source,java] | ||
| ---- | ||
| grid.setItemsPageable(pageable -> productService.list(pageable, somethingElse)); | ||
| ---- |
There was a problem hiding this comment.
Not sure what's the goal of adding this code snippet as it shows how one can modify the service method, whereas the same setItemsPageable is used here.
There was a problem hiding this comment.
I'd replace somethingElse with a meaningful example, e.g. a full text search string filter.
mshabarov
approved these changes
Mar 11, 2025
|
Something is better than nothing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4136