Skip to content

fix: Ensure row is visible before getting it #7260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: Ensure row is visible before getting it #7260

wants to merge 4 commits into from

Conversation

TatuLund
Copy link
Contributor

@TatuLund TatuLund commented Apr 1, 2025 •
edited
Loading

TatuLund added 4 commits April 1, 2025 13:03
@TatuLund
fix: Ensure row is visible before getting it
8a3546e
@TatuLund
Fix test
c417c3d 
The previous version needed to use scrollTo as workaround, and now expected needs to be calculated before adding row as it is high enough to cause scroll to called internally.
@TatuLund
Add getRow(int, boolean) to skip scrolling
3479528
@TatuLund
Do not allow scrolling in the test
c7bc66f
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GridElement.getRow() returns null even if it shouldn't
1 participant
@TatuLund