Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: execute Hilla tasks whenever Hilla is available #20567

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

tepi
Copy link
Contributor

@tepi tepi commented Nov 27, 2024

Execute Hilla tasks (TaskGenerateOpenAPI and TaskGenerateEndpoint) whenever Hilla is available on the classpath. These tasks should determine the required actions themselves, instead of Flow trying to do it.

Fixes #20289
Fixes #18800

Copy link

github-actions bot commented Nov 27, 2024

Test Results

1 165 files  +175  1 165 suites  +175   1h 36m 3s ⏱️ + 8m 43s
7 639 tests + 14  7 582 ✅ + 14  57 💤 ±0  0 ❌ ±0 
7 953 runs  +251  7 890 ✅ +245  63 💤 +6  0 ❌ ±0 

Results for commit 9ef9b9c. ± Comparison against base commit f5c972a.

♻️ This comment has been updated with latest results.

@tepi
Copy link
Contributor Author

tepi commented Dec 4, 2024

For reviewers to test this:

  1. You need local clones of flow, hilla and platform repos
  2. For Flow checkout this branch, for Hilla checkout this branch, for Platform checkout main branch
  3. Build flow: mvn clean install -DskipTests
  4. Build hilla: npm run build , then mvn clean install -DskipTests
  5. Build vaadin maven plugin: mvn clean install -DskipTests in platform/vaadin-maven-plugin
  6. After that test with a project from start, using 24.6-SNAPSHOT as the vaadin version

@tepi
Copy link
Contributor Author

tepi commented Dec 5, 2024

@mshabarov When you have time could you check that it still works for your use case with the latest change?

mshabarov
mshabarov previously approved these changes Dec 5, 2024
Copy link
Contributor

@mshabarov mshabarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test manually with the following scenarios:

  1. Vaadin app has only Java views and a ReactAdapter
  2. Vaadin app has only TS view
  3. Vaadin app has a TS view and a ReactAdapter.

Works as expected. LGTM.

@mshabarov
Copy link
Contributor

⚠️ Let's not merge this until we get a green light from Hilla team for vaadin/hilla#2938.

@mshabarov mshabarov marked this pull request as draft December 10, 2024 11:59
@mshabarov mshabarov force-pushed the feat/endpoint-detection branch from 7ca001f to 9a1c149 Compare December 19, 2024 12:40
@mshabarov mshabarov changed the base branch from 24.6 to main December 19, 2024 12:41
mshabarov
mshabarov previously approved these changes Dec 19, 2024
@tepi tepi force-pushed the feat/endpoint-detection branch from 281f16a to 0d19eb1 Compare January 17, 2025 13:54
@tepi tepi changed the title feat: add endpoint detection feat: execute Hilla tasks whenever Hilla is available Jan 17, 2025
@vaadin-bot vaadin-bot added +0.0.1 and removed +0.1.0 labels Jan 17, 2025
@tepi tepi marked this pull request as ready for review January 30, 2025 10:09
@tepi tepi requested a review from mshabarov January 30, 2025 10:09
@mshabarov mshabarov merged commit 21a4145 into main Feb 3, 2025
26 checks passed
@mshabarov mshabarov deleted the feat/endpoint-detection branch February 3, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants