fix: compute client-side feature flag values at runtime #21066
Conversation
mcollovati
force-pushed
the
issues/20992-feature_flag_not_in_bundle
branch
from
06b51a8 to
e499842
Compare
Test Results1 169 files ± 0 1 169 suites ±0 1h 15m 56s ⏱️ - 1m 44s Results for commit 91ff0db. ± Comparison against base commit 9b2dad4. This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Activating a feature flag in the project does not work when a default bundle is used because the values of the flags sent to the client are hard-coded at bundle build time. Additionally, if a feature flag is active during bundle creation, it remains active on the client side even if the project does not activate it in the `vaadin-featureflags.properties` file. This change ensures that feature flags in the frontend bundle are always disabled initially and are activated on page load based on the current project settings. Fixes #20991
mcollovati
force-pushed
the
issues/20992-feature_flag_not_in_bundle
branch
from
e499842 to
91ff0db
Compare
|
|
Hi @mcollovati and @mshabarov, when i performed cherry-pick to this commit to 24.7, i have encountered the following issue. Can you take a look and pick it manually? |
Activating a feature flag in the project does not work when a default bundle is used because the values of the flags sent to the client are hard-coded at bundle build time. Additionally, if a feature flag is active during bundle creation, it remains active on the client side even if the project does not activate it in the `vaadin-featureflags.properties` file. This change ensures that feature flags in the frontend bundle are always disabled initially and are activated on page load based on the current project settings. Fixes #20991
) Activating a feature flag in the project does not work when a default bundle is used because the values of the flags sent to the client are hard-coded at bundle build time. Additionally, if a feature flag is active during bundle creation, it remains active on the client side even if the project does not activate it in the `vaadin-featureflags.properties` file. This change ensures that feature flags in the frontend bundle are always disabled initially and are activated on page load based on the current project settings. Fixes #20991
Activating a feature flag in the project does not work when a default bundle is used because the values of the flags sent to the client are hard-coded at bundle build time. Additionally, if a feature flag is active during bundle creation, it remains active on the client side even if the project does not activate it in the
vaadin-featureflags.propertiesfile.This change ensures that feature flags in the frontend bundle are always disabled initially and are activated on page load based on the current project settings.
Fixes #20991