fix: prevent failure when Spring MainClassFinder is not available #3210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3210 +/- ##
=======================================
Coverage 86.91% 86.91%
=======================================
Files 118 118
Lines 8191 8191
Branches 1256 1256
=======================================
Hits 7119 7119
Misses 1058 1058
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
If AotBrowserCallableFinder is invoked by flow-maven-plugin, it fails because the dependency to org.springframework.boot:spring-boot-loader-tools that contains the MainClassFinder is provided only by hilla-maven-plugin and vaadin-maven-plugin. This can happen for example in MPR projects that are forced to use flow-maven-plugin because they require the Vaadin 8 version of vaadin-maven-plugin. This change catches the failure and provide some insight on how to potentially fix the issue, by excluding Hilla or using hilla-maven-plugin. Fixes #3206
mcollovati
force-pushed
the
issues/3206-taskgenerateopenapi_classnotfound
branch
from
18489b2 to
be3f8d8
Compare
cromoteca
previously approved these changes
Feb 10, 2025
mcollovati
commented
Feb 10, 2025
packages/java/engine-core/src/main/java/com/vaadin/hilla/engine/AotBrowserCallableFinder.java
Outdated
Show resolved
Hide resolved
|
cromoteca
approved these changes
Feb 11, 2025
|
This ticket/PR has been released with Hilla 24.7.0.alpha12 and is also targeting the upcoming stable 24.7.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If AotBrowserCallableFinder is invoked by flow-maven-plugin, it fails because the dependency to
org.springframework.boot:spring-boot-loader-tools that contains the MainClassFinder is provided only by hilla-maven-plugin and vaadin-maven-plugin.
This can happen for example in MPR projects that are forced to use flow-maven-plugin because they require the Vaadin 8 version of vaadin-maven-plugin.
This change catches the failure and provide some insight on how to potentially fix the issue, by excluding Hilla or using hilla-maven-plugin.
Fixes #3206
Type of change
Checklist
Additional for
Featuretype of change