-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Laos holidays #1483
Add Laos holidays #1483
Conversation
Pull Request Test Coverage Report for Build 6354322299
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PPsyrius, thank you for another great work! 👍 Please look at few suggestions.
Co-Authored-By: ~Jhellico <[email protected]>
Co-authored-by: ~Jhellico <[email protected]>
Co-authored-by: ~Jhellico <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so cool! I can't appreciate enough your help with Thai based calendar holidays!
I hope we still have time to include this new country calendar into v0.34.
Please take a look at my comments when you have a chance:
Co-Authored-By: Arkadii Yakovets <[email protected]>
Head branch was pushed to by a user without write access
Turns out my commit that fixes up the Laotian language source accidentally disabled the In any case, that change is in now @arkid15r |
That's fine, I still don't know all the features of this workflow as we've enabled it just a week or two ago.
You still have another on L49. Otherwise LGTM, very well done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🇱🇦 LGTM
Proposed change
Add Laos holidays (
en_US
,lo
,th
localization;BANK
,PUBLIC
,SCHOOL
,WORKDAY
category).Based on:
Checked with:
Closes #1215.
Type of change
Checklist
beta
branch of the repositorymake pre-commit
command generates no changesmake test
,make tox
(we strongly encourage adding tests to your code)