Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Laos holidays #1483

Merged
merged 19 commits into from
Sep 29, 2023
Merged

Add Laos holidays #1483

merged 19 commits into from
Sep 29, 2023

Conversation

PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Sep 26, 2023

Proposed change

Add Laos holidays (en_US, lo, th localization; BANK, PUBLIC, SCHOOL, WORKDAY category).

Based on:

Checked with:

Closes #1215.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

@coveralls
Copy link

coveralls commented Sep 26, 2023

Pull Request Test Coverage Report for Build 6354322299

  • 173 of 173 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6341209667: 0.0%
Covered Lines: 9541
Relevant Lines: 9541

💛 - Coveralls

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PPsyrius, thank you for another great work! 👍 Please look at few suggestions.

holidays/calendars/thai.py Show resolved Hide resolved
holidays/countries/laos.py Outdated Show resolved Hide resolved
holidays/countries/laos.py Outdated Show resolved Hide resolved
holidays/countries/laos.py Outdated Show resolved Hide resolved
holidays/countries/laos.py Outdated Show resolved Hide resolved
@PPsyrius PPsyrius requested a review from KJhellico September 27, 2023 12:14
Co-authored-by: ~Jhellico <[email protected]>
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so cool! I can't appreciate enough your help with Thai based calendar holidays!

I hope we still have time to include this new country calendar into v0.34.

Please take a look at my comments when you have a chance:

holidays/calendars/thai.py Outdated Show resolved Hide resolved
holidays/calendars/thai.py Outdated Show resolved Hide resolved
holidays/countries/laos.py Outdated Show resolved Hide resolved
holidays/locale/en_US/LC_MESSAGES/LA.po Outdated Show resolved Hide resolved
holidays/observed_holiday_base.py Outdated Show resolved Hide resolved
holidays/observed_holiday_base.py Outdated Show resolved Hide resolved
tests/calendars/test_thai.py Show resolved Hide resolved
@PPsyrius PPsyrius requested a review from arkid15r September 28, 2023 19:07
@arkid15r arkid15r enabled auto-merge September 28, 2023 19:31
auto-merge was automatically disabled September 29, 2023 03:10

Head branch was pushed to by a user without write access

@PPsyrius
Copy link
Collaborator Author

Turns out my commit that fixes up the Laotian language source accidentally disabled the auto-merge...

In any case, that change is in now @arkid15r

@arkid15r
Copy link
Collaborator

Turns out my commit that fixes up the Laotian language source accidentally disabled the auto-merge...

That's fine, I still don't know all the features of this workflow as we've enabled it just a week or two ago.

In any case, that change is in now @arkid15r

You still have another on L49.

Otherwise LGTM, very well done!

@arkid15r arkid15r enabled auto-merge September 29, 2023 16:55
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇱🇦 LGTM

@arkid15r arkid15r added this pull request to the merge queue Sep 29, 2023
Merged via the queue into vacanza:beta with commit 12e524a Sep 29, 2023
22 checks passed
@PPsyrius PPsyrius deleted the laos_holidays branch October 2, 2023 03:17
@arkid15r arkid15r mentioned this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Laos holidays
4 participants