Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Thailand holidays: name change for October 13 holiday #1493

Merged
merged 7 commits into from
Oct 9, 2023

Conversation

PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Oct 2, 2023

Proposed change

This PR adjusted the name for Thailand's October 13 holiday to "วันนวมินทรมหาราช" (HM King Bhumibol Adulyadej Memorial Day) as per new government announcement on September 26, 2023, as well as some test case simplification.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

@coveralls
Copy link

coveralls commented Oct 2, 2023

Pull Request Test Coverage Report for Build 6390092592

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6384409515: 0.0%
Covered Lines: 9541
Relevant Lines: 9541

💛 - Coveralls

@PPsyrius PPsyrius requested a review from KJhellico October 3, 2023 09:00
KJhellico
KJhellico previously approved these changes Oct 3, 2023
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇹🇭 LGTM

@arkid15r arkid15r added this pull request to the merge queue Oct 9, 2023
Merged via the queue into vacanza:beta with commit 0f71c73 Oct 9, 2023
22 checks passed
@PPsyrius PPsyrius deleted the th_oct_13_name_update branch October 9, 2023 19:40
@KJhellico KJhellico mentioned this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants