-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Maldives holidays #1508
Add Maldives holidays #1508
Conversation
Pull Request Test Coverage Report for Build 6502297718
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kasya, thank you for new country! 👍 Please look at few suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great to see another country support added to the library.
Nicely done, @kasya!
…ays into add-maldives-holidays
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Proposed change
Initial support for Maldives holidays.
Type of change
Checklist
make pre-commit
command generates no changesmake test
,make tox
(we strongly encourage adding tests to your code)