Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mypy version from 1.5.1 to 1.6.0 #1511

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

arkid15r
Copy link
Collaborator

Proposed change

Bump mypy version from 1.5.1 to 1.6.0
Change HolidayBase return type casting from abstract Mapping to more specific Dict (fix mypy operator error).

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)

Change HolidayBase  return type casting from abstract Mapping
to more specific Dict (fix mypy operator error).
@arkid15r arkid15r requested a review from KJhellico as a code owner October 12, 2023 02:28
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6490529083

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.977%

Totals Coverage Status
Change from base Build 6477281223: 0.0%
Covered Lines: 9716
Relevant Lines: 9716

💛 - Coveralls

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, essence of this change seems to me to be some kind of magic. 😃

@arkid15r arkid15r added this pull request to the merge queue Oct 12, 2023
Merged via the queue into vacanza:beta with commit c42b985 Oct 12, 2023
22 checks passed
@arkid15r arkid15r deleted the update-precommit branch October 12, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants