-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update China holidays: add observed and substituted holidays in 2001-2024 #1613
Conversation
Pull Request Test Coverage Report for Build 7389607481Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving the Chinese calendar, here are some of the Thai language translations that likely need to be changed here. 👀
@PPsyrius, thank you! It's Google Translate 🤷🏻♂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, does this PR close #1601 ?
Yes, this includes holidays shifting in 2024. |
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 16 New issues |
Proposed change
Resolves #1601
Update China holidays: add observed and substituted holidays in 2001-2024.
Type of change
Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally