-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dev env setup issues #1627
Fix dev env setup issues #1627
Conversation
Also ,I solved the issue in #1603 |
Pull Request Test Coverage Report for Build 7430053729Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
restore to origin
restore to origin
follows the resoures managers' advice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for addressing the issues
Co-authored-by: ~Jhellico <[email protected]>
add "make package" into setup
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging this, thank you @peter-ni-noob !
upd: it seems this requires an explicit @KJhellico's approval: Merging can be performed automatically once the requested changes are addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Proposed change
Addressing environmental set-up issues of this projects for new contributors, command "make package" is useful to set up environment of this project when begining this project or updating the version of project for avertting error when "make test".
Type of change
Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally