Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev env setup issues #1627

Merged
merged 9 commits into from
Jan 6, 2024
Merged

Fix dev env setup issues #1627

merged 9 commits into from
Jan 6, 2024

Conversation

peter-ni-noob
Copy link
Contributor

Proposed change

Addressing environmental set-up issues of this projects for new contributors, command "make package" is useful to set up environment of this project when begining this project or updating the version of project for avertting error when "make test".

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@peter-ni-noob
Copy link
Contributor Author

Also ,I solved the issue in #1603

@coveralls
Copy link

coveralls commented Jan 4, 2024

Pull Request Test Coverage Report for Build 7430053729

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7402025732: 0.0%
Covered Lines: 10244
Relevant Lines: 10244

💛 - Coveralls

.gitignore Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
scripts/generate_release_notes.py Show resolved Hide resolved
restore to origin
follows the resoures managers' advice.
scripts/generate_release_notes.py Outdated Show resolved Hide resolved
@arkid15r arkid15r changed the title Addressing environmental set-up issues of this projects for new contributors Fix dev env setup issues Jan 5, 2024
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for addressing the issues

CONTRIBUTING.rst Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Jan 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@arkid15r arkid15r enabled auto-merge January 6, 2024 17:46
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this, thank you @peter-ni-noob !

upd: it seems this requires an explicit @KJhellico's approval: Merging can be performed automatically once the requested changes are addressed.

@arkid15r arkid15r requested a review from KJhellico January 6, 2024 17:47
@arkid15r arkid15r disabled auto-merge January 6, 2024 17:53
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r added this pull request to the merge queue Jan 6, 2024
Merged via the queue into vacanza:beta with commit cfab69d Jan 6, 2024
26 checks passed
@arkid15r arkid15r mentioned this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants