-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce observed_estimated_label #1633
Introduce observed_estimated_label #1633
Conversation
Pull Request Test Coverage Report for Build 7465501273
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i18n support is something awesome... 🤪
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've addressed the comments and added an extra check for estimated/observed_estimated labels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Proposed change
While reviewing #1615 I noticed cases with the extra brackets "(estimated) (observed)" label text inconsistency. This PR is aimed to address the first problem.
Type of change
Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally