-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add United Kingdom's Whit Monday holidays for pre-1971 years #1668
Conversation
Pull Request Test Coverage Report for Build 7678311138
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An excellent point about Whit Monday absence! 👍
Co-authored-by: ~Jhellico <[email protected]>
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🇬🇧 🇮🇲 LGTM
Proposed change
As spotted in #1664, this implements the following changes for United Kingdom holidays:
ENG
), Wales (WLS
), and North Ireland (NIR
).Type of change
Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally