Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add United Kingdom's Whit Monday holidays for pre-1971 years #1668

Merged
merged 5 commits into from
Feb 1, 2024

Conversation

PPsyrius
Copy link
Collaborator

Proposed change

As spotted in #1664, this implements the following changes for United Kingdom holidays:

  • Implements Whit Monday holidays from 1871 onwards until its eventual replacement by Spring bank holidays in 1971 for England (ENG), Wales (WLS), and North Ireland (NIR).
  • Add a cut-off date; thus, bank holidays are no longer available before the implementation of the Bank Holidays Act 1871.
  • In-Lieu observance only took effect from 1875 onwards as decreed in the Bank Holidays Extension Act 1875.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@coveralls
Copy link

coveralls commented Jan 26, 2024

Pull Request Test Coverage Report for Build 7678311138

  • 0 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7672154552: 0.0%
Covered Lines: 10440
Relevant Lines: 10440

💛 - Coveralls

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An excellent point about Whit Monday absence! 👍

holidays/countries/united_kingdom.py Outdated Show resolved Hide resolved
holidays/countries/united_kingdom.py Show resolved Hide resolved
@PPsyrius PPsyrius requested a review from KJhellico January 26, 2024 12:34
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇬🇧 🇮🇲 LGTM

@arkid15r arkid15r added this pull request to the merge queue Feb 1, 2024
Merged via the queue into vacanza:beta with commit 5506de9 Feb 1, 2024
26 checks passed
@PPsyrius PPsyrius deleted the UK_whit_monday branch February 2, 2024 03:27
@KJhellico KJhellico mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants