-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ruff instead of black+flake8 #1671
Conversation
From a quick glance, it seems like you'll need to set a separate max-string-length to 99 again, too, in the [tool.ruff.lint.flake8-errmsg]
max-string-length = 99 Update: here's the setting I play around with to mimic the existing linter rules we have - interestingly enough, [tool.ruff]
line-length = 99
target-version = "py38"
[tool.ruff.lint]
# Skip Whitespace before ':' (E203).
ignore = ["E203"] IMO, once rust properly supports |
Pull Request Test Coverage Report for Build 7701360664Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added flake8-errmsg
suggestion (even though it doesn't seem to make any difference for now). The E203 one is still in preview, I guess it can wait.
LGTM! let's ruff it! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right, I've fixed those " " cases!
Thanks for the thorough review! 👍
-- Co-authored-by: ~Jhellico <[email protected]>
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 8 New issues |
Proposed change
Resolves #1670
Switched to ruff. It works great, had to make some modifications though.
Type of change
Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally