Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Taiwan holidays #1688

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Update Taiwan holidays #1688

merged 3 commits into from
Feb 13, 2024

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Update Taiwan holidays (add substituted holidays according to official sources from 2010).

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@KJhellico KJhellico requested a review from PPsyrius February 7, 2024 17:44
@KJhellico KJhellico requested a review from arkid15r as a code owner February 7, 2024 17:44
@coveralls
Copy link

coveralls commented Feb 7, 2024

Pull Request Test Coverage Report for Build 7886435879

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 31 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7793210723: 0.0%
Covered Lines: 10518
Relevant Lines: 10518

💛 - Coveralls

Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work finding all those exact holiday lists from the 2010s👍

snapshots/countries/TW_COMMON.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇹🇼

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

holidays/countries/taiwan.py Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@arkid15r arkid15r enabled auto-merge February 13, 2024 17:51
@arkid15r arkid15r added this pull request to the merge queue Feb 13, 2024
Merged via the queue into vacanza:beta with commit 0ce30b4 Feb 13, 2024
26 checks passed
@KJhellico KJhellico deleted the upd-taiwan branch February 13, 2024 18:18
@arkid15r arkid15r mentioned this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants