Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Portugal holidays: fix Carnival date #1694

Merged
merged 2 commits into from
Feb 19, 2024
+7 −7
Merged

Update Portugal holidays: fix Carnival date #1694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f734733
Updated Carnival holiday for Portugal to be on a tuesday and not a mo…
DgRosa Feb 19, 2024
718225b
Merge branch 'beta' into fix-portugal-carnival-holiday-date
DgRosa Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion holidays/countries/portugal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def _populate_optional_holidays(self):
# - get Holidays that occur on Thursday and add Friday (+1 day)

# Carnival.
self._add_carnival_monday(tr("Carnaval"))
self._add_carnival_tuesday(tr("Carnaval"))

# St. Anthony's Day.
self._add_holiday_jun_13(tr("Dia de Santo António"))
Expand Down
12 changes: 6 additions & 6 deletions tests/countries/test_portugal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,17 +153,17 @@ def test_optional_holidays(self):
holidays = Portugal(categories=OPTIONAL, years=range(2017, 2020))
self.assertHoliday(
holidays,
"2017-02-27",
"2017-02-28",
"2017-06-13",
"2017-12-24",
"2017-12-26",
"2017-12-31",
"2018-02-12",
"2018-02-13",
"2018-06-13",
"2018-12-24",
"2018-12-26",
"2018-12-31",
"2019-03-04",
"2019-03-05",
"2019-06-13",
"2019-12-24",
"2019-12-26",
Expand Down Expand Up @@ -243,7 +243,7 @@ def test_portugal_day(self):
def test_l10n_default(self):
self.assertLocalizedHolidays(
("2018-01-01", "Ano Novo"),
("2018-02-12", "Carnaval"),
("2018-02-13", "Carnaval"),
("2018-03-30", "Sexta-feira Santa"),
("2018-04-01", "Páscoa"),
("2018-04-25", "Dia da Liberdade"),
Expand All @@ -266,7 +266,7 @@ def test_l10n_en_us(self):
self.assertLocalizedHolidays(
"en_US",
("2018-01-01", "New Year's Day"),
("2018-02-12", "Carnival"),
("2018-02-13", "Carnival"),
("2018-03-30", "Good Friday"),
("2018-04-01", "Easter Sunday"),
("2018-04-25", "Freedom Day"),
Expand All @@ -289,7 +289,7 @@ def test_l10n_uk(self):
self.assertLocalizedHolidays(
"uk",
("2022-01-01", "Новий рік"),
("2022-02-28", "Карнавал"),
("2022-03-01", "Карнавал"),
("2022-04-15", "Страсна пʼятниця"),
("2022-04-17", "Великдень"),
("2022-04-25", "День Свободи"),
Expand Down