Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RELEASE.rst #1698

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Update RELEASE.rst #1698

merged 1 commit into from
Feb 19, 2024

Conversation

arkid15r
Copy link
Collaborator

Proposed change

Update instructions according to the recent changes.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@arkid15r arkid15r requested a review from KJhellico as a code owner February 19, 2024 18:19
@coveralls
Copy link

coveralls commented Feb 19, 2024

Pull Request Test Coverage Report for Build 7964326443

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7964097026: 0.0%
Covered Lines: 10547
Relevant Lines: 10547

💛 - Coveralls

@arkid15r arkid15r changed the base branch from beta to dev February 19, 2024 18:43
KJhellico
KJhellico previously approved these changes Feb 19, 2024
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r force-pushed the update-release-howto branch from 60f314a to 4db0b53 Compare February 19, 2024 19:22
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@arkid15r arkid15r enabled auto-merge February 19, 2024 19:28
@arkid15r arkid15r requested a review from KJhellico February 19, 2024 19:28
@arkid15r arkid15r added this pull request to the merge queue Feb 19, 2024
Merged via the queue into vacanza:dev with commit 1e7f39b Feb 19, 2024
23 checks passed
@arkid15r arkid15r deleted the update-release-howto branch February 19, 2024 19:29
@KJhellico KJhellico mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants