Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snapshots: Portugal holidays #1709

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Mar 1, 2024

Proposed change

This PR updates Portuguese Holidays snapshot from changes implemented in #1694 for project-wide consistency.

(in the long term we might want a GitHub action that automatically run make snapshot in the background for every PR before they're merged in)

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8106263340

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8105363435: 0.0%
Covered Lines: 10547
Relevant Lines: 10547

💛 - Coveralls

@arkid15r arkid15r enabled auto-merge March 1, 2024 17:47
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇵🇹 LGTM

@arkid15r arkid15r added this pull request to the merge queue Mar 1, 2024
Merged via the queue into vacanza:dev with commit c7d6ef0 Mar 1, 2024
26 checks passed
@arkid15r arkid15r changed the title Update Portuguese holidays snapshot Update snapshots: Portugal holidays Mar 1, 2024
@PPsyrius PPsyrius deleted the update_PT_snapshot branch March 2, 2024 15:33
@KJhellico KJhellico mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants