-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add French subdivision aliases #2162
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2162 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 194 194
Lines 11540 11541 +1
Branches 1641 1641
=========================================
+ Hits 11540 11541 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🇫🇷
I had to look up in the source code what MQ, RE... meant. The README didn't help either, just listing the raw codes available. Those are not of common use in the French culture, contrary to say, AZ meaning Arizona in the US culture. Also fixed the official spelling.
fd6c080
to
5362815
Compare
Quality Gate passedIssues Measures |
Sorry, I updated my PR after your review to write "La Réunion" everywhere for consistency. That was also an opportunity to rebase on the upstream branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR subdivs are still somewhat inconsistent with ISO 3166 but for v0
it's fine.
Thank you for adding this @bors-ltd
@bors-ltd FYI we started requiring signed commits this month however it's not checked on pre-commit or CI/CD so I'm accepting this one as is. Please look into setting this up if you're planning to contribute to holidays in future. Thank you! |
Thanks, I'll have a look at ISO 3166, and find out how to sign my commit if I have something to iterate on. |
Proposed change
I had to look up in the source code what MQ, RE... meant. The README didn't help either, just listing the raw codes available.
Those are not of common use in the French culture, contrary to say, AZ meaning Arizona in the US culture.
Also fixed the official spelling.
Type of change
holidays
functionality in general)Checklist
make check
, all checks and tests are green## Additional notes
For the record, it started with me adding a holiday calendar in my Home Assistant. I was left puzzled with that list:
And when I couldn't find the meaning of those abbreviations in the documentation either, I thought it was time to contribute.
The next step is to get in touch with the maintainers of this Home Assistant integration, and ask them to use the list of subdivision aliases when available.