-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HebrewCalendarHolidays
to holidays groups, refactor Israel holidays
#2186
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2186 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 194 195 +1
Lines 11657 11679 +22
Branches 1691 1685 -6
=========================================
+ Hits 11657 11679 +22 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this refactoring is long overdue. Thanks for addressing it!
de94ef7
to
f140153
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for keeping it well-structured.
Proposed change
Add
HebrewCalendarHolidays
to holidays groups (for use in other countries with Hebrew holidays); refactor Israel holidays.Type of change
holidays
functionality in general)Checklist
make check
, all checks and tests are green