Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add South Korea's temporary public holidays #2217

Closed
wants to merge 1 commit into from
Closed

Add South Korea's temporary public holidays #2217

wants to merge 1 commit into from

Conversation

YiGeon
Copy link
Contributor

@YiGeon YiGeon commented Jan 8, 2025

Add South Korea's temporary public holidays to January 27th, 2024.

Proposed change

Your PR description goes here.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@YiGeon
Add South Korea's temporary public holidays
f4c0cb4 
Add South Korea's temporary public holidays to January 27th, 2024.
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@YiGeon YiGeon closed this Jan 8, 2025
@YiGeon
Copy link
Contributor Author

YiGeon commented Jan 8, 2025

Sorry, it's January 27, 2025, but I added it in 2024

@YiGeon YiGeon deleted the add-korea-holiday branch January 8, 2025 01:37
@arkid15r
Copy link
Collaborator

arkid15r commented Jan 8, 2025

@YiGeon that's fine, just update this PR, don't close/open new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r Awaiting requested review from arkid15r arkid15r is a code owner

@KJhellico KJhellico Awaiting requested review from KJhellico KJhellico is a code owner

@PPsyrius PPsyrius Awaiting requested review from PPsyrius PPsyrius is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YiGeon @arkid15r