-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Hong Kong holidays: add l10n support #2268
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2268 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 199 199
Lines 12144 12148 +4
Branches 1731 1731
=========================================
+ Hits 12144 12148 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PPsyrius, great work! 👍 When I worked on Hong Kong last time, I tried to leave comment with Chinese name for all holidays, with the aim of l10n. I hope this was helpful.
Just a few suggestions:
Quality Gate failedFailed conditions |
At some point, we’ll likely need to implement support for Since each has a distinct |
Proposed change
en_HK
), American English (en_US
), Traditional Chinese (zh_HK
), Simplified Chinese (zh_CN
), Thai (th
) localization support - withzh_HK
as the new default l10n option.Note
I'm using
zh_HK
instead ofzh_TW
for Hong Kong's Traditional Chinese l10n for now since I'm not sure if both Taiwanese and Hong Konger ones are the same or not.Type of change
holidays
functionality in general)Checklist
make check
, all checks and tests are green