Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The current state and future plan of the waku-rln-relay project #143

Closed
wants to merge 7 commits into from

Conversation

staheri14
Copy link
Contributor

@staheri14 staheri14 commented Oct 24, 2022

This is to address the last part of the second testnet tasks list i.e.,

A writeup describing the goal of the cross-client testnet, the journey, future steps, studies around performance, and relation to operator outreach

The relation to operator outreach will be clarified separately in the operator outreach document.

This post can be published as a forum post or a research post. Open to suggestions.
I opened it as a PR here to ease the review process, once the decision reached about where to publish this doc, I'll move it to the relevant repo accordingly.

@staheri14 staheri14 requested review from oskarth, s1fr0 and rymnc October 24, 2022 23:44
Copy link

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
minor nits. IMO this should be a research post 😄

rln-research/2022-07-22-rln-relay-journey.md Outdated Show resolved Hide resolved
rln-research/2022-07-22-rln-relay-journey.md Outdated Show resolved Hide resolved
rln-research/2022-07-22-rln-relay-journey.md Outdated Show resolved Hide resolved
rln-research/2022-07-22-rln-relay-journey.md Outdated Show resolved Hide resolved
rln-research/2022-07-22-rln-relay-journey.md Outdated Show resolved Hide resolved
rln-research/2022-07-22-rln-relay-journey.md Outdated Show resolved Hide resolved
rln-research/2022-07-22-rln-relay-journey.md Outdated Show resolved Hide resolved
rln-research/2022-07-22-rln-relay-journey.md Outdated Show resolved Hide resolved
rln-research/2022-07-22-rln-relay-journey.md Outdated Show resolved Hide resolved
rln-research/2022-07-22-rln-relay-journey.md Outdated Show resolved Hide resolved
Copy link
Contributor

@s1fr0 s1fr0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left some nitpick comments

rln-research/2022-07-22-rln-relay-journey.md Outdated Show resolved Hide resolved
rln-research/2022-07-22-rln-relay-journey.md Outdated Show resolved Hide resolved
rln-research/2022-07-22-rln-relay-journey.md Outdated Show resolved Hide resolved
rln-research/2022-07-22-rln-relay-journey.md Outdated Show resolved Hide resolved
rln-research/2022-07-22-rln-relay-journey.md Outdated Show resolved Hide resolved
rln-research/2022-07-22-rln-relay-journey.md Outdated Show resolved Hide resolved
rln-research/2022-07-22-rln-relay-journey.md Outdated Show resolved Hide resolved
rln-research/2022-07-22-rln-relay-journey.md Outdated Show resolved Hide resolved
rln-research/2022-07-22-rln-relay-journey.md Outdated Show resolved Hide resolved
rln-research/2022-07-22-rln-relay-journey.md Outdated Show resolved Hide resolved
@staheri14
Copy link
Contributor Author

staheri14 commented Oct 26, 2022

Thank you @rymnc and @s1fr0 for your comments, please see the revised version of the post based on the comments in cd6791e and 985457a.

@staheri14 staheri14 self-assigned this Oct 26, 2022
Copy link
Contributor

@oskarth oskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked over it briefly and seems OK. I'd post as a research post.

published: true
permalink: /waku-rln-relay-journey
categories: research
summary: The current state of the research and development of the WAKU-RLN-RELAY project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This summary could be better:

  • Doesn't help someone who doesn't already know what RLN or RLN RELAY is.

  • It also doesn't hint at what the main delta is from last post (e.g. cross client on-chain testnet, etc) - can use a few keywords in a list to give people a better view of what the post about.

The first XX words of the summary shows up in e.g. Twitter view

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't help someone who doesn't already know what RLN or RLN RELAY is.

Fair point.

It also doesn't hint at what the main delta is from last post (e.g. cross client on-chain testnet, etc) - can use a few keywords in a list to give people a better view of what the post about.

Sure.

The first XX words of the summary shows up in e.g. Twitter view

Noted.

Please check the following commit 5e3ab81



**Academic publications**: The results of this project are published as 2 academic research articles in prestigious conferences of ICDCS and DINPS 2022.
They are accessible at https://arxiv.org/pdf/2207.00117.pdf and https://ieeexplore.ieee.org/abstract/document/9912176/.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what s1fr0 is getting at is that this should be mentioned in the text. A question in a PR review of a text is usually feedback on the text itself, and just answering the PR comment doesn't actually improve the text...


# WAKU-RLN-RELAY: Why and How

**Why**: The WAKU-RLN-RELAY project was started more than two years ago to protect the open p2p messaging protocol of [WAKU-RELAY](https://rfc.vac.dev/spec/11/) against spam and DDoS attacks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link back to previous post on RLN

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, done 33d5b37

@oskarth
Copy link
Contributor

oskarth commented Nov 1, 2022

Given that:

  1. We didn't get this out before Devcon
  2. We have my talk at Devcon that'll be up as a write-up soon, as well as Franck's new post: waku product update vac.dev#78 being out soon
  3. We are gonna "rebrand" as RLNP2P

Perhaps we should save this write-up until we've done some work on RLNP2P?

@staheri14
Copy link
Contributor Author

staheri14 commented Nov 2, 2022

I think what s1fr0 is getting at is that this should be mentioned in the text. A question in a PR review of a text is usually feedback on the text itself, and just answering the PR comment doesn't actually improve the text...

I agree and that is what I do, but this question didn't seem to require an update on the text as the separation of the two articles is pretty evident as the publication venues and links are not the same. Will stress on this more by putting the title of the articles. Please check 5528be6.

@staheri14
Copy link
Contributor Author

Perhaps we should save this write-up until we've done some work on RLNP2P?

Fine for me, then going to close this PR and keep the write-up locally until the due time comes.

@staheri14 staheri14 closed this Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants