Fix utxos sorting to sort before grouping #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidTranDucVL
force-pushed
the
fix-utxos-ordering
branch
from
a67db76 to
51767e3
Compare
DavidTranDucVL
temporarily deployed
to
adalite-fix-utxos-order-pkjzwn
DavidTranDucVL
temporarily deployed
to
adalite-fix-utxos-order-pkjzwn
DavidTranDucVL
force-pushed
the
fix-utxos-ordering
branch
from
bf8b341 to
51767e3
Compare
DavidTranDucVL
temporarily deployed
to
adalite-fix-utxos-order-pkjzwn
refi93
force-pushed
the
fix-utxos-ordering
branch
from
51767e3 to
d0485c2
Compare
refi93
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug introduced in #1174 which basically negated all the arranging of utxos as it sorted the utxos after the partitioning (which respects the order of utxos supplied) rather than before, resulting in a suboptimal tx plan being computed in terms of transaction size/fees