Remove exceptions from public and private key code #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relatko
force-pushed
the
to_merge_with_LedgerHQ_1_0_5b
branch
3 times, most recently
from
da76cee to
f6ceb9c
Compare
relatko
force-pushed
the
to_merge_with_LedgerHQ_1_0_5b
branch
from
f6ceb9c to
5d55ca6
Compare
relatko
force-pushed
the
to_merge_with_LedgerHQ_1_0_5b
branch
from
873c61c to
a3661c6
Compare
relatko
force-pushed
the
to_merge_with_LedgerHQ_1_0_5b
branch
from
0732e0b to
83703bf
Compare
relatko
force-pushed
the
to_merge_with_LedgerHQ_1_0_5b
branch
from
44e50fc to
7eb02b9
Compare
janmazak
reviewed
Oct 25, 2023
src/signTransaction.c
Outdated
| G_io_apdu_buffer, | ||
| &bufferLen); | ||
| if (err != SUCCESS) { | ||
| THROW(err); |
There was a problem hiding this comment.
no need to zero G_io_apdu_buffer?
src/utils.h
Outdated
| { \ | ||
| if (!(condition)) { \ | ||
| TRACE(); \ | ||
| error_to_return = error; \ |
There was a problem hiding this comment.
Suggested change
| error_to_return = error; \ | |
| error_to_return = (error); \ |
relatko
force-pushed
the
to_merge_with_LedgerHQ_1_0_5b
branch
from
e0797fc to
755ccf5
Compare
relatko
force-pushed
the
to_merge_with_LedgerHQ_1_0_5b
branch
from
755ccf5 to
7d38be1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.