Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danger verbose fix #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ferrettmerr
Copy link

When running danger local or danger pr the --verbose flag is added. This causes all methods to get called and danger-xcodebuild crashes anytime @xcodebuild_json is accessed since it is nil.

I added return unless @xcodebuild_json to prevent the crash.

@valeriomazzeo
Copy link
Owner

valeriomazzeo commented Apr 6, 2017

@ferrettmerr Thanks for the pull request.

As you can see CI build is failing. Could you please update the specs too?

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants