Fix shadowing bug

valida-xyz · Jan 24, 2024 · fd6c848 · fd6c848
1 parent 27bf713
commit fd6c848
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/cpu/src/lib.rs b/cpu/src/lib.rs
@@ -263,12 +263,12 @@ impl CpuChip {
             let word_1 = CPU_COL_MAP.mem_channels[0]
                 .value
                 .into_iter()
-                .map(|i| rows[i][i])
+                .map(|j| rows[i][j])
                 .collect::<Vec<_>>();
             let word_2 = CPU_COL_MAP.mem_channels[1]
                 .value
                 .into_iter()
-                .map(|i| rows[i][i])
+                .map(|j| rows[i][j])
                 .collect::<Vec<_>>();
             for (a, b) in word_1.into_iter().zip(word_2) {
                 diff[i] += (a - b).square();

diff --git a/cpu/src/stark.rs b/cpu/src/stark.rs
@@ -257,7 +257,7 @@ impl CpuChip {
                 .read_value_1()
                 .into_iter()
                 .zip(local.read_value_2())
-                .map(|(a, b)| (a - b) * (a - b))
+                .map(|(a, b)| (a - b).square())
                 .sum::<AB::Expr>(),
         );
         builder.assert_bool(local.not_equal);