Add truncated loadu8. #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 26, 2024 09:06
morganthomas
approved these changes
Apr 28, 2024
|
This won't be implementable in the STARK without increasing the number of memory channels, because this instruction's semantics require three read channels and one write channel, but currently we only have two read channels and one write channel. A better solution long term may be to eliminate this opcode in a compiler pass, replacing it with a sequence of instructions. |
morganthomas
pushed a commit
that referenced
this pull request
Apr 30, 2024
…8" (#165) This reverts commit 4057c01, reversing changes made to e4c92a9. Co-authored-by: thealmarty <“[email protected]”>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No regression in the tests with these changes, including the
storeu8andloadu8tests. Theloadu8test includes atloadu8instruction. However,load_bytecurrently has a read before write error, which will be separately fixed.