Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow immediate b operand for LT instruction. #92

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

thealmarty
Copy link
Collaborator

@thealmarty thealmarty commented Jan 10, 2024

Before the change, the tests for ILT return an error:

2024-1-ilt-neg
+ ./llvm-valida/build/bin/clang -c -target delendum ./llvm-test-suite/SingleSource/UnitTests/2024-1-ilt-neg.c -o 2024-1-ilt-neg.o
+ ./llvm-valida/build/bin/ld.lld --script=./llvm-valida/valida.ld -o ./2024-1-ilt-neg.out ./2024-1-ilt-neg.o
+ ./llvm-valida/build/bin/llvm-objcopy -O binary ./2024-1-ilt-neg.out ./2024-1-ilt-neg.out.bin
+ ./valida-mc-fixer/result/bin/valida-mc-fixer ./2024-1-ilt-neg.out.bin ./2024-1-ilt-neg.out.bin.fix
+ ./valida-mc-fixer/result/bin/valida-mc-fixer -d ./2024-1-ilt-neg.out.bin.fix 2024-1-ilt-neg.s
+ echo 'running program'
running program
+ timeout 3 ./valida/target/release/valida ./2024-1-ilt-neg.out.bin.fix
thread 'main' panicked at memory/src/lib.rs:67:30:
memory chip: read before write: 16777226 (pc = 8, opcode = 104, ordinal = 0, extra_info = )
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

With the change, the tests are running as expected (when https://github.com/lita-xyz/llvm-valida/pull/52 is merged).

@thealmarty
Copy link
Collaborator Author

See https://github.com/lita-xyz/llvm-valida/pull/52#issue-2075128392 for instructions to reproduce the tests.

Copy link
Collaborator

@dlubarov dlubarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thealmarty thealmarty force-pushed the thealmarty/issue/13lt branch from 2dc88b5 to a3cc8c0 Compare January 11, 2024 17:36
@thealmarty thealmarty force-pushed the thealmarty/issue/13lt branch from a3cc8c0 to 162fca8 Compare January 11, 2024 18:06
@thealmarty thealmarty merged commit 413bb4c into main Jan 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants