Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NE and EQ instructions #98

Merged
merged 7 commits into from
Jan 25, 2024
Merged

Add NE and EQ instructions #98

merged 7 commits into from
Jan 25, 2024

Conversation

thealmarty
Copy link
Collaborator

@thealmarty thealmarty commented Jan 15, 2024 •
edited
Loading

Before the changes, the following tests had "unrecognized opcode" errors. After the changes, the tests are behaving as expected:

2023-12-log-not 2023-12-log-not-neg 2023-12-log-and 2023-12-log-and-neg

@thealmarty thealmarty force-pushed the thealmarty/issue/13com branch 3 times, most recently from 5641c74 to 9e48bf3 Compare January 16, 2024 17:47
@thealmarty thealmarty marked this pull request as ready for review January 16, 2024 18:08
dlubarov
dlubarov reviewed Jan 16, 2024
View reviewed changes
alu_u32/src/com/stark.rs Outdated Show resolved Hide resolved
dlubarov
dlubarov reviewed Jan 16, 2024
View reviewed changes
alu_u32/src/com/stark.rs Outdated Show resolved Hide resolved
@thealmarty thealmarty requested a review from dlubarov January 17, 2024 17:23
dlubarov
dlubarov approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@dlubarov dlubarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i.e. the current version without those two lines seems right to me, but let me know if I misunderstood something there

@thealmarty thealmarty force-pushed the thealmarty/issue/13com branch 2 times, most recently from 0653389 to 5af1f7c Compare January 24, 2024 19:39
@thealmarty thealmarty force-pushed the thealmarty/issue/13com branch from 5af1f7c to 77a6573 Compare January 25, 2024 16:58
@thealmarty
Copy link
Collaborator Author

I've re-tested and no regression. Merging.

@thealmarty thealmarty merged commit 84ea7d2 into main Jan 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlubarov dlubarov dlubarov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thealmarty @dlubarov