Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kubescape Plugin #24

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add Kubescape Plugin #24

wants to merge 3 commits into from

Conversation

wcrum
Copy link
Member

@wcrum wcrum commented Jun 17, 2024

Description

Adds support for validator-plugin-kubescape

@wcrum wcrum requested a review from a team as a code owner June 17, 2024 17:03
@wcrum wcrum requested a review from TylerGillson June 17, 2024 17:03
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 63.09524% with 62 lines in your changes missing coverage. Please review.

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   53.30%   53.58%   +0.28%     
==========================================
  Files          41       42       +1     
  Lines        4206     4365     +159     
==========================================
+ Hits         2242     2339      +97     
- Misses       1380     1411      +31     
- Partials      584      615      +31     
Files Coverage Δ
pkg/config/constants.go 100.00% <ø> (ø)
...integration/_validator/testcases/test_validator.go 94.90% <100.00%> (+0.33%) ⬆️
pkg/services/validator/validator_service.go 38.60% <33.33%> (-0.16%) ⬇️
pkg/cmd/validator/validator.go 59.95% <79.31%> (+0.61%) ⬆️
pkg/components/validator.go 60.00% <63.63%> (+0.16%) ⬆️
pkg/services/validator/kubescape.go 50.56% <50.56%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b58097...95809b4. Read the comment docs.

Copy link
Member

@TylerGillson TylerGillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking pretty good, but it needs to be refactored to support plugin reconfiguration.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants