Bitstring logging improved (HEX)

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.3.12
+
+* Improve bitstring logging.
+
 ## 0.3.11
 
 * Elixir 1.15 (OTP 26) warnings fixed.

lib/rtu/master.ex

@@ -177,7 +177,7 @@ defmodule Modbux.Rtu.Master do
 
   def handle_call({:request, cmd}, _from, state) do
     uart_frame = Rtu.pack_req(cmd)
-    Logger.debug("(#{__MODULE__}) Frame: #{inspect(uart_frame <> <<0x00>>)}")
+    Logger.debug("(#{__MODULE__}) Frame: #{inspect(uart_frame, base: :hex)}")
     UART.flush(state.uart_pid)
     UART.write(state.uart_pid, uart_frame)
 

lib/rtu/slave.ex

@@ -178,7 +178,7 @@ defmodule Modbux.Rtu.Slave do
   end
 
   def handle_info({:circuits_uart, device, {:error, reason, bad_frame}}, state) do
-    Logger.warning("(#{__MODULE__}) Error with \"#{device}\" received: #{bad_frame}, reason: #{reason}")
+    Logger.warning("(#{__MODULE__}) Error with \"#{device}\" received: #{inspect(bad_frame, base: :hex)}, reason: #{reason}")
 
     case reason do
       :einval ->

lib/tcp/server/server_handler.ex

@@ -22,7 +22,7 @@ defmodule Modbux.Tcp.Server.Handler do
   end
 
   def handle_info({:tcp, socket, data}, state) do
-    Logger.debug("(#{__MODULE__}) Received: #{data} ")
+    Logger.debug("(#{__MODULE__}) Received: #{inspect(data, base: :hex)} ")
     {cmd, transid} = Tcp.parse_req(data)
     Logger.debug("(#{__MODULE__}) Received Modbux request: #{inspect({cmd, transid})}")
 

lib/tcp/tcp.ex

@@ -59,7 +59,10 @@ defmodule Modbux.Tcp do
       if size == r_size do
         payload
       else
-        Logger.error("#{__MODULE__} size = #{size}, payload_size = #{r_size}, msg = #{inspect(msg)}")
+        Logger.error(
+          "#{__MODULE__} size = #{size}, payload_size = #{r_size}, msg = #{inspect(msg, base: :hex)}"
+        )
+
         nil
       end
 
@@ -73,7 +76,7 @@ defmodule Modbux.Tcp do
   end
 
   def unwrap(inv_data) do
-    Logger.error("#{__MODULE__} invalid data: #{inspect(inv_data)}")
+    Logger.error("#{__MODULE__} invalid data: #{inspect(inv_data, base: :hex)}")
     raise("#{__MODULE__} invalid data: #{inspect(inv_data)}")
   end
 end

mix.exs

@@ -1,7 +1,7 @@
 defmodule Modbux.Mixfile do
   use Mix.Project
 
-  @version "0.3.11"
+  @version "0.3.12"
   @source_url "https://github.com/valiot/modbux"
 
 

test/tcp/modbus_tcp_client_test.exs

@@ -15,7 +15,7 @@ defmodule ModbuxTcpClientTest do
   end
 
   test "test Client errors" do
-    {:ok, cpid} = Client.start_link(ip: {127, 0, 0, 1}, port: 5000)
+    {:ok, cpid} = Client.start_link(ip: {127, 0, 0, 1}, tcp_port: 5000)
     assert {:error, :econnrefused} == Client.connect(cpid)
     assert {:error, :closed} == Client.close(cpid)
   end