Handle empty addresses in CLUSTER NODES responses
#148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the `noaddr` flag instead of the address length when checking that a node has an address. Empty addresses are valid and can be replaced with the endpoint that was used when sending the command. Signed-off-by: Björn Svensson <[email protected]>
Treat an empty ip string as it means the same endpoint that the current command was sent to. Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
zuiderkwast
approved these changes
Jan 15, 2025
Signed-off-by: Björn Svensson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing a
CLUSTER NODESresponse we will now treat an empty IP string as it means the same endpoint as the response came from. This due to that the docs mention that an empty string is returned for the IP field when the node doesn't know its own IP address.The created
valkeyClusterNodewill get its address from thevalkeyContextused when sending the command.Additional changes are that we will use the
noaddrflag instead of the address length when deciding when a node should be skipped; and added validation of the port.Example of a response snippet with an empty address:
"752d150249c157c7cb312b6b056517bbbecb42d2 :6379@16379 myself,master - 1658754833817 1658754833000 3 connected 5461-10922"