Extract error sorting code to module. #1077
Conversation
This will allow FFI clients to use the same logic.
glide-core/src/errors.rs
Outdated
| Unspecified, | ||
| ExecAbort, | ||
| Timeout, | ||
| Disconnect, |
There was a problem hiding this comment.
ClosingError is missing
There was a problem hiding this comment.
when would an FFI client return a closing error?
There was a problem hiding this comment.
Is closing error applicable for UDS clients only?
There was a problem hiding this comment.
ATM yes. Only UDS clients have a shared resource that might be reach an unusable state.
There was a problem hiding this comment.
correction: an FFI wrapper also has a shared resource - the client itself. if the wrapper releases the client, it has reached closing state. but that's pure wrapper-side logic.
|
Java CI fails, because on error scenarios (e.g. wrong arguments) it received request_error {
type: Disconnect
message: "Received connection error `An error was signalled by the server - ResponseError: hash value is not an integer`. Will attempt to reconnect"
} |
nihohit
force-pushed
the
errors
branch
2 times, most recently
from
735e8a9 to
cc8d8ec
Compare
* Extract error sorting code to module. This will allow FFI clients to use the same logic. * ++redis-rs * fix comments.
This will allow FFI clients to use the same logic.
Issue #, if available:
#1066
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.