Node: Brpop Command #1113
Merged
Node: Brpop Command #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avifenesh
requested review from
barshaul,
asafpamzn,
shachlanAmazon,
shohamazon and
adanWattad
avifenesh
force-pushed
the
Commands/TS/BRPOP
branch
from
7a3bb36 to
efca2f6
Compare
barshaul
reviewed
Mar 19, 2024
barshaul
reviewed
Mar 19, 2024
node/src/Transaction.ts
Outdated
| * | ||
| * @param keys - The `keys` of the lists to pop from. | ||
| * @param timeout - The `timeout` in seconds. | ||
| * @returns - `Array` of the `key` that elements were poped from, and the popped elements, or null if timeout is reached. |
There was a problem hiding this comment.
We don't use @returns in transactions but Command Response: (see below)
There was a problem hiding this comment.
I'll fix, but its not consistent throw the file, a lot of the function use returns. Need to be aligned in another PR.
There was a problem hiding this comment.
Can you please open a fix for that?
There was a problem hiding this comment.
What is a fix? like issue, or you ask to fix?
barshaul
requested changes
Mar 19, 2024
avifenesh
force-pushed
the
Commands/TS/BRPOP
branch
from
efca2f6 to
b6f3f3a
Compare
avifenesh
force-pushed
the
Commands/TS/BRPOP
branch
from
b6f3f3a to
8915385
Compare
shohamazon
reviewed
Mar 19, 2024
shohamazon
reviewed
Mar 19, 2024
avifenesh
force-pushed
the
Commands/TS/BRPOP
branch
3 times, most recently
from
a6d33ac to
041df4c
Compare
avifenesh
force-pushed
the
Commands/TS/BRPOP
branch
2 times, most recently
from
07311e8 to
a44a9ef
Compare
avifenesh
force-pushed
the
Commands/TS/BRPOP
branch
from
a44a9ef to
98b447e
Compare
barshaul
approved these changes
Mar 24, 2024
node/src/Transaction.ts
Outdated
| * | ||
| * @param keys - The `keys` of the lists to pop from. | ||
| * @param timeout - The `timeout` in seconds. | ||
| * @returns - `Array` of the `key` that elements were poped from, and the popped elements, or null if timeout is reached. |
There was a problem hiding this comment.
Can you please open a fix for that?
avifenesh
force-pushed
the
Commands/TS/BRPOP
branch
from
98b447e to
563129b
Compare
avifenesh
force-pushed
the
Commands/TS/BRPOP
branch
from
563129b to
86a8fc7
Compare
shohamazon
pushed a commit
to adanWattad/glide-for-redis
that referenced
this pull request
Apr 9, 2024
Add BRPOP command to node
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
Add BRPOP command to node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Brpop command to TS
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.