Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Added Zpopmin command. (Sorted Set Commands) #1165

Merged

Conversation

SanHalacogluImproving
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@SanHalacogluImproving SanHalacogluImproving requested a review from a team as a code owner March 22, 2024 20:26
@acarbonetto acarbonetto added the java issues and fixes related to the java client label Mar 22, 2024
@acarbonetto acarbonetto changed the title Java: Added Zpopmin command. (Sorted Set Commands) (#150) Java: Added Zpopmin command. (Sorted Set Commands) Mar 22, 2024
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts

java/client/src/test/java/glide/api/RedisClientTest.java Outdated Show resolved Hide resolved
Comment on lines 1254 to 1255
* @return Command Response - A map of the removed members and their scores, ordered from the one
* with the highest score to the one with the lowest.<br>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this contradictory with the line above?

@shohamazon shohamazon self-assigned this Apr 1, 2024
@SanHalacogluImproving SanHalacogluImproving force-pushed the java/integ_SanH_add_Zpopmin branch from 4655130 to 899560d Compare April 1, 2024 20:02
@Yury-Fridlyand Yury-Fridlyand merged commit 961a1bb into valkey-io:main Apr 1, 2024
12 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the java/integ_SanH_add_Zpopmin branch April 1, 2024 20:30
shohamazon pushed a commit to adanWattad/glide-for-redis that referenced this pull request Apr 9, 2024
* Java: Added Zpopmin command. (Sorted Set Commands) (valkey-io#150)
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 24, 2024
* Java: Added Zpopmin command. (Sorted Set Commands) (#150)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java issues and fixes related to the java client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants