C#: Split debug and release Rust compilation. #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yury-Fridlyand
approved these changes
Apr 2, 2024
Sa1Gur
reviewed
Apr 2, 2024
| </Target> | ||
|
|
||
| <ItemGroup> | ||
| <Content Include="$(MSBuildThisFileDirectory)target/release/libglide_rs.dll" Condition="$([MSBuild]::IsOSPlatform('Windows'))"> |
There was a problem hiding this comment.
I think we should use path
csharp/lib/glide.csproj
Outdated
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
| <Link>%(FileName)%(Extension)</Link> | ||
| </Content> | ||
| <Content Include="$(MSBuildThisFileDirectory)target/release/libglide_rs.so" Condition="$([MSBuild]::IsOSPlatform('Linux')) And '$(Configuration)' == 'Release'"> |
There was a problem hiding this comment.
could use
csharp/lib/glide.csproj
Outdated
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
| <Link>%(FileName)%(Extension)</Link> | ||
| </Content> | ||
| <Content Include="$(MSBuildThisFileDirectory)target/release/libglide_rs.dylib" Condition="$([MSBuild]::IsOSPlatform('OSX')) And '$(Configuration)' == 'Release'"> |
There was a problem hiding this comment.
could use
Before this change, Rust was always compiled in release mode. This allows tests to compile in debug mode, which cuts the compilation time from ~1:20 minutes to 0:30.
shachlanAmazon
approved these changes
Apr 2, 2024
shohamazon
pushed a commit
to adanWattad/glide-for-redis
that referenced
this pull request
Apr 9, 2024
Before this change, Rust was always compiled in release mode. This allows tests to compile in debug mode, which cuts the compilation time from ~1:20 minutes to 0:30.
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
Before this change, Rust was always compiled in release mode. This allows tests to compile in debug mode, which cuts the compilation time from ~1:20 minutes to 0:30.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, Rust was always compiled in release mode. This allows tests to compile in debug mode, which cuts the compilation time from ~1:20 minutes to 0:30.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.