Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: Add Zmscore command. (Sorted Set Command Group) #1234

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Java: Add Zmscore command. (Sorted Set Command Group) #1234

merged 6 commits into from
Apr 10, 2024

Conversation

SanHalacogluImproving
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@SanHalacogluImproving SanHalacogluImproving requested a review from a team as a code owner April 4, 2024 19:29
Yury-Fridlyand
Yury-Fridlyand approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, resolve merge conflicts

CHANGELOG.md Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java Outdated Show resolved Hide resolved
@Yury-Fridlyand Yury-Fridlyand added the java issues and fixes related to the java client label Apr 5, 2024
@acarbonetto acarbonetto changed the title Java: Add Zmscore command. (Sorted Set Command Group) (#173) Java: Add Zmscore command. (Sorted Set Command Group) Apr 5, 2024
barshaul
barshaul reviewed Apr 10, 2024
View reviewed changes
java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java
* @see <a href="https://redis.io/commands/zmscore/">redis.io</a> for more details.
* @param key The key of the sorted set.
* @param members An array of members in the sorted set.
* @return An <code>Array</code> of scores of the <code>members</code>.<br>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens if the key doesn't exist? what if the key doesn't hold a sorted set?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the key doesn't exist, the same thing happens, returns null for all corresponding members. If the key is not a set that is an error condition and we do not document error conditions. This is the same as PY and Node.

barshaul
barshaul approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@barshaul barshaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix & merge

@SanHalacogluImproving SanHalacogluImproving force-pushed the java/integ_SanH_add_Zmscore branch from 526626e to d755b35 Compare April 10, 2024 18:33
@SanHalacogluImproving SanHalacogluImproving force-pushed the java/integ_SanH_add_Zmscore branch from e2a7585 to 0cb7989 Compare April 10, 2024 19:18
@acarbonetto acarbonetto merged commit 4ce976c into valkey-io:main Apr 10, 2024
44 of 45 checks passed
@acarbonetto acarbonetto deleted the java/integ_SanH_add_Zmscore branch April 10, 2024 19:37
Sa1Gur pushed a commit to Sa1Gur/glide-for-redis that referenced this pull request Apr 10, 2024
Squashed commit of the following:
c7ac523 
commit 0a430cf
Author: Andrew Carbonetto <[email protected]>
Date:   Wed Apr 10 13:30:02 2024 -0700

    Java/Node: Update docs for `xadd` and `xtrim` (valkey-io#1246)

    * Java: Add XADD command (Stream commands) (valkey-io#155)

    * Add Stream XADD command to Java

    Signed-off-by: Andrew Carbonetto <[email protected]>

    ---------

    Signed-off-by: Andrew Carbonetto <[email protected]>

    * Java: Add Zpopmax command. (Sorted Set Commands) (valkey-io#1164)

    * Java: Add Zpopmax command. (Sorted Set Commands) (valkey-io#149)

    * Minor documentation update.

    * Minor test update.

    * Spotless

    Signed-off-by: Andrew Carbonetto <[email protected]>

    * Minor documentation update.

    * Rebase + Spotless

    ---------

    Signed-off-by: Andrew Carbonetto <[email protected]>
    Co-authored-by: Andrew Carbonetto <[email protected]>

    * Spotless

    Signed-off-by: Andrew Carbonetto <[email protected]>

    * Clean up merge

    Signed-off-by: Andrew Carbonetto <[email protected]>

    * Move xadd command

    Signed-off-by: Andrew Carbonetto <[email protected]>

    * Spotless

    Signed-off-by: Andrew Carbonetto <[email protected]>

    * PR comments.

    Signed-off-by: Yury-Fridlyand <[email protected]>

    * Update xtrim documentation

    Signed-off-by: Andrew Carbonetto <[email protected]>

    * Spotless

    Signed-off-by: Andrew Carbonetto <[email protected]>

    ---------

    Signed-off-by: Andrew Carbonetto <[email protected]>
    Signed-off-by: Yury-Fridlyand <[email protected]>
    Co-authored-by: SanHalacogluImproving <[email protected]>
    Co-authored-by: Yury-Fridlyand <[email protected]>

commit 4ce976c
Author: SanHalacogluImproving <[email protected]>
Date:   Wed Apr 10 12:36:56 2024 -0700

    Java: Add `Zmscore` command. (Sorted Set Command Group) (valkey-io#1234)

    * Java: Add Zmscore command. (Sorted Set Command Group) (valkey-io#173)

    * Minor update + remove change log.

    * Minor documentation update.

    * Minor IT update.

    * Rebase + Spotless.

    * Minor IT test update.

commit ae0a8f4
Author: Yury-Fridlyand <[email protected]>
Date:   Wed Apr 10 12:33:22 2024 -0700

    Java: Refactor transaction UT (valkey-io#1242)

    Refactor transaction UT. (valkey-io#192)

    Signed-off-by: Yury-Fridlyand <[email protected]>

commit fec74b8
Author: Andrew Carbonetto <[email protected]>
Date:   Wed Apr 10 12:28:18 2024 -0700

    Clean up all warnings in Java client test (valkey-io#1213)

    * Clean up all warnings in Java client test

    Signed-off-by: Andrew Carbonetto <[email protected]>

    ---------

    Signed-off-by: Andrew Carbonetto <[email protected]>

    * Clean FfiTest.java of warnings

    Signed-off-by: Andrew Carbonetto <[email protected]>

    * Clean RedisClusterClientTest.java of compiler warnings

    Signed-off-by: Andrew Carbonetto <[email protected]>

    * Clean up more warnings in client tests

    Signed-off-by: Andrew Carbonetto <[email protected]>

    * Spotless

    Signed-off-by: Andrew Carbonetto <[email protected]>

    * Fix UT + update IT.

    Signed-off-by: Yury-Fridlyand <[email protected]>

    * Update suppression.

    Signed-off-by: Yury-Fridlyand <[email protected]>

    * Remove suppress warnings

    Signed-off-by: Andrew Carbonetto <[email protected]>

    ---------

    Signed-off-by: Andrew Carbonetto <[email protected]>
    Signed-off-by: Yury-Fridlyand <[email protected]>
    Co-authored-by: Yury-Fridlyand <[email protected]>

commit 527e1ec
Author: SanHalacogluImproving <[email protected]>
Date:   Wed Apr 10 12:06:01 2024 -0700

    Java: Add `lindex` command. (List Command Group) (valkey-io#1219)

    * Java: Add lindex command. (List Command Group) (valkey-io#158)

    * Minor documentation update + changed param from int to long + minor IT update.

commit d766f51
Author: Andrew Carbonetto <[email protected]>
Date:   Wed Apr 10 10:01:55 2024 -0700

    Node: Fix build section for node DEVELOPER.md (valkey-io#1250)

    * Fix build section for node DEVELOPER.md

    Signed-off-by: Andrew Carbonetto <[email protected]>

    * Fix numbers in DEVELOPER.md

    Signed-off-by: Andrew Carbonetto <[email protected]>

    * Run prettier

    ---------

    Signed-off-by: Andrew Carbonetto <[email protected]>
    Co-authored-by: Jonathan Louie <[email protected]>

commit 939a519
Author: jonathanl-bq <[email protected]>
Date:   Wed Apr 10 09:08:43 2024 -0700

    Java: Use LinkedHashMap instead of HashMap for Java wrapper Map values returned from Redis (valkey-io#1257)

    * Use LinkedHashMap instead of HashMap for Java wrapper Map values returned from Redis

    * Run cargo fmt

commit d21dbc9
Author: Shoham Elias <[email protected]>
Date:   Wed Apr 10 18:02:22 2024 +0300

    add missing examples and minor doc fix (valkey-io#1258)

commit 09bec2d
Author: ort-bot <[email protected]>
Date:   Wed Apr 10 00:19:09 2024 +0000

    Updated attribution files

commit 4e7acdc
Author: Adan Wattad <[email protected]>
Date:   Wed Apr 10 11:11:21 2024 +0300

    Node: added zrange and zrangeWithScores commands. (valkey-io#1115)

    ---------

    Co-authored-by: Adan <[email protected]>
    Co-authored-by: Shoham Elias <[email protected]>
    Co-authored-by: Shoham Elias <[email protected]>

commit 79c49a4
Author: Gilboab <[email protected]>
Date:   Wed Apr 10 10:53:16 2024 +0300

    Python: Added RENAME command (valkey-io#1252)

    Python: Added rename command

commit 78cfa33
Author: Adan Wattad <[email protected]>
Date:   Tue Apr 9 14:29:45 2024 +0300

    Node: added spop and spopCount commands. (valkey-io#1117)

    Co-authored-by: Shoham Elias <[email protected]>

commit 5395fe1
Author: Shoham Elias <[email protected]>
Date:   Tue Apr 9 12:23:59 2024 +0300

    Python: adds ZREMRANGEBYSCORE command (valkey-io#1151)
alex-arzola-imp pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Apr 12, 2024
@SanHalacogluImproving @alex-arzola-imp
Java: Add Zmscore command. (Sorted Set Command Group) (valkey-io#1234)
100deb7 
* Java: Add Zmscore command. (Sorted Set Command Group) (#173)

* Minor update + remove change log.

* Minor documentation update.

* Minor IT update.

* Rebase + Spotless.

* Minor IT test update.
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 24, 2024
@SanHalacogluImproving @cyip10
Java: Add Zmscore command. (Sorted Set Command Group) (valkey-io#1234)
7e3c17a 
* Java: Add Zmscore command. (Sorted Set Command Group) (#173)

* Minor update + remove change log.

* Minor documentation update.

* Minor IT update.

* Rebase + Spotless.

* Minor IT test update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acarbonetto acarbonetto acarbonetto approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@barshaul barshaul barshaul approved these changes

@aaron-congo aaron-congo Awaiting requested review from aaron-congo

@jonathanl-bq jonathanl-bq Awaiting requested review from jonathanl-bq

@alex-arzola-imp alex-arzola-imp Awaiting requested review from alex-arzola-imp

@shohamazon shohamazon Awaiting requested review from shohamazon

@adanWattad adanWattad Awaiting requested review from adanWattad

Assignees
No one assigned
Labels
java issues and fixes related to the java client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SanHalacogluImproving @barshaul @Yury-Fridlyand @acarbonetto