Java: Add SETRANGE command.
#1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `SETRANGE` command. Signed-off-by: Yury-Fridlyand <[email protected]> * PR comments. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]>
acarbonetto
approved these changes
Apr 4, 2024
java/client/src/main/java/glide/api/commands/StringCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/StringCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/StringCommands.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Yury-Fridlyand <[email protected]>
|
Will resolve conflicts later, after merging few more PRs pending |
acarbonetto
reviewed
Apr 5, 2024
|
No |
SanHalacogluImproving
approved these changes
Apr 5, 2024
java/client/src/main/java/glide/api/commands/StringCommands.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Yury-Fridlyand <[email protected]>
…TRANGE Signed-off-by: Yury-Fridlyand <[email protected]>
barshaul
reviewed
Apr 10, 2024
| * @param key The key of the string to update. | ||
| * @param offset The position in the string where <code>value</code> should be written. | ||
| * @param value The string written with <code>offset</code>. | ||
| * @return The length of the string stored at <code>key</code> after it was modified. |
There was a problem hiding this comment.
If key holds a value that is not a string, an error is returned.
There was a problem hiding this comment.
We do not document error cases for all commands to keep docs easy.
This comment is applicable to all commands - do you want to add it to a common place? readme?
barshaul
reviewed
Apr 10, 2024
java/client/src/main/java/glide/api/commands/StringBaseCommands.java
Outdated
Show resolved
Hide resolved
barshaul
reviewed
Apr 10, 2024
| * @return The length of the string stored at <code>key</code> after it was modified. | ||
| * @example | ||
| * <pre>{@code | ||
| * long len = client.setrange("key", 6, "GLIDE").get(); |
There was a problem hiding this comment.
@acarbonetto
Please make sure that the examples compile
There was a problem hiding this comment.
Updated. Both are ok and compilable
barshaul
reviewed
Apr 10, 2024
| int offset = 42; | ||
| String str = "pewpew"; | ||
| String[] arguments = new String[] {key, Integer.toString(offset), str}; | ||
| Long value = 10L; |
There was a problem hiding this comment.
minor: value -> responseValue (value is confusing in the key-value context)
There was a problem hiding this comment.
There are 99 tests in this file and almost all of them have variable named "value".
I'm going to refactor tests in another PR (and rename the var). Is it OK for you?
There was a problem hiding this comment.
commandResult or futureResult is even less ambiguous.
barshaul
approved these changes
Apr 10, 2024
Signed-off-by: Yury-Fridlyand <[email protected]>
…TRANGE Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Elen-Ghulam
approved these changes
Apr 11, 2024
alex-arzola-imp
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Apr 12, 2024
* Add `SETRANGE` command. (#183) * Add `SETRANGE` command. Signed-off-by: Yury-Fridlyand <[email protected]> * PR comments. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> * PR comments. Signed-off-by: Yury-Fridlyand <[email protected]> * PR comments. Signed-off-by: Yury-Fridlyand <[email protected]> * Typo fix. Signed-off-by: Yury-Fridlyand <[email protected]> * Update UT. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]>
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
* Add `SETRANGE` command. (#183) * Add `SETRANGE` command. Signed-off-by: Yury-Fridlyand <[email protected]> * PR comments. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> * PR comments. Signed-off-by: Yury-Fridlyand <[email protected]> * PR comments. Signed-off-by: Yury-Fridlyand <[email protected]> * Typo fix. Signed-off-by: Yury-Fridlyand <[email protected]> * Update UT. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Add
SETRANGEcommand. https://redis.io/commands/setrange/By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.