Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Add Zrandmember command. (Sorted Set Commands) #1238

Merged

Conversation

SanHalacogluImproving
Copy link
Contributor

@SanHalacogluImproving SanHalacogluImproving commented Apr 5, 2024

Issue #, if available:

Description of changes:
https://redis.io/docs/latest/commands/zrandmember/

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@SanHalacogluImproving SanHalacogluImproving requested a review from a team as a code owner April 5, 2024 20:26
@Yury-Fridlyand Yury-Fridlyand added the java issues and fixes related to the java client label Apr 6, 2024
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add data conversion, then update return type, docs and tests
Then resolve merge conflicts

@acarbonetto acarbonetto changed the title Java: Add Zrandmember command. (Sorted Set Commands) (#175) Java: Add Zrandmember command. (Sorted Set Commands) Apr 8, 2024
@acarbonetto acarbonetto marked this pull request as draft April 10, 2024 17:22
@acarbonetto
Copy link
Contributor

Converted to draft: waiting on approval for the return type conversion design.

@acarbonetto acarbonetto marked this pull request as ready for review April 16, 2024 18:54
@acarbonetto acarbonetto removed their assignment Apr 16, 2024
@Yury-Fridlyand Yury-Fridlyand marked this pull request as draft May 2, 2024 21:32
SanHalacogluImproving and others added 2 commits May 6, 2024 21:00
Co-authored-by: SanHalacogluImproving <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand force-pushed the java/integ_SanH_add_Zrandmember branch from b19f3f8 to 2c41c5b Compare May 8, 2024 01:07
@Yury-Fridlyand Yury-Fridlyand marked this pull request as ready for review May 8, 2024 01:28
Copy link
Contributor

@acarbonetto acarbonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix merge conflict

Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand and others added 2 commits May 9, 2024 13:15
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand merged commit d4ffa99 into valkey-io:main May 10, 2024
45 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the java/integ_SanH_add_Zrandmember branch May 10, 2024 01:14
avifenesh pushed a commit that referenced this pull request May 14, 2024
* Java: Add Zrandmember command. (Sorted Set Commands) (#175)

Signed-off-by: Yury-Fridlyand <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]>
Co-authored-by: Aaron <[email protected]>
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 24, 2024
* Java: Add Zrandmember command. (Sorted Set Commands) (#175)

Signed-off-by: Yury-Fridlyand <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]>
Co-authored-by: Aaron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java issues and fixes related to the java client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants