Java: Add RENAMENX command.
#1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
requested review from
aaron-congo,
acarbonetto and
SanHalacogluImproving
aaron-congo
reviewed
Apr 24, 2024
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
| @@ -1975,6 +1976,21 @@ public T type(@NonNull String key) { | |||
| return getThis(); | |||
| } | |||
|
|
|||
| /** | |||
| * Renames <code>key</code> to <code>newKey</code> if <code>newKey</code> does not yet exist. | |||
There was a problem hiding this comment.
I can't remember, is the api note about keys needing to map to the same hash slot not applicable here?
There was a problem hiding this comment.
We don't add to transaction, because
- transaction could be routed to one node only
- if route not given, GLIDE core picks a route for the transaction according to the keys used referenced in it
A user may still route a transaction to a wrong node intentionally, on it own responsibility.
Signed-off-by: Yury-Fridlyand <[email protected]>
…NAMENX Signed-off-by: Yury-Fridlyand <[email protected]>
aaron-congo
approved these changes
Apr 25, 2024
acarbonetto
approved these changes
Apr 25, 2024
…NAMENX Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Elen-Ghulam
approved these changes
Apr 27, 2024
…NAMENX Signed-off-by: Yury-Fridlyand <[email protected]>
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
* Add `RENAMENX` command. (#247) Signed-off-by: Yury-Fridlyand <[email protected]> * PR comments. Signed-off-by: Yury-Fridlyand <[email protected]> * Update IT. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
https://redis.io/docs/latest/commands/renamenx/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.