Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI workflows. #1358

Closed
wants to merge 1 commit into from
Closed

Fix CI workflows. #1358

wants to merge 1 commit into from

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Apr 27, 2024 •
edited
Loading

  1. use macos-12 instead of macos-latest
  2. prepare to switch from ubuntu-latest to ubunty-$ver
  3. disable CD workflows on forks
  4. Fixes CI rediness for C#, node and python

Meanwhile AWS_REGION secret is missing, CD workflows are still red.

@Yury-Fridlyand
Fix CI workflows. (#252)
c8d978a 
* Try to fix CI workflows.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Fix CD.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Revert CI renames.

Signed-off-by: Yury-Fridlyand <[email protected]>

* PR comments.

Signed-off-by: Yury-Fridlyand <[email protected]>

---------

Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand added the CI/CD CI/CD related label Apr 27, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner April 27, 2024 00:16
@barshaul
Copy link
Collaborator

Meanwhile AWS_REGION secret is missing, CD workflows are still red.

The secret isn't missing, you cannot retrieve secrets when opening a PR from a fork. The PR branch must be on the main upstream repository.
I will pull these changes and open a PR from the upstream to make sure it works.
Thanks Yuri.

@barshaul barshaul mentioned this pull request Apr 30, 2024
Merged
@barshaul
Copy link
Collaborator

Moved to PR #1364

@barshaul barshaul closed this Apr 30, 2024
@Yury-Fridlyand Yury-Fridlyand deleted the ci/integ_yuryf_fix_all branch April 30, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanl-bq jonathanl-bq Awaiting requested review from jonathanl-bq

@acarbonetto acarbonetto Awaiting requested review from acarbonetto

@SanHalacogluImproving SanHalacogluImproving Awaiting requested review from SanHalacogluImproving

@avifenesh avifenesh Awaiting requested review from avifenesh

@barshaul barshaul Awaiting requested review from barshaul

@shohamazon shohamazon Awaiting requested review from shohamazon

@ikolomi ikolomi Awaiting requested review from ikolomi

Assignees
No one assigned
Labels
CI/CD CI/CD related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yury-Fridlyand @barshaul