Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: adds HKEYS command #1499

Closed
wants to merge 7 commits into from
Closed

Conversation

adarovadya
Copy link
Collaborator

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@adarovadya adarovadya requested a review from a team as a code owner May 30, 2024 19:46
@adarovadya adarovadya requested a review from shohamazon May 30, 2024 19:47
@Yury-Fridlyand Yury-Fridlyand added the node Node.js wrapper label May 30, 2024
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add CHANGELOG entry

node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/Transaction.ts Outdated Show resolved Hide resolved
node/tests/SharedTests.ts Outdated Show resolved Hide resolved
@adarovadya adarovadya force-pushed the hkeys-node branch 2 times, most recently from ae7cc09 to 6e6dd88 Compare June 2, 2024 17:06
node/.prettierignore Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
node/src/Transaction.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@avifenesh avifenesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments - they are minor

Copy link
Collaborator

@avifenesh avifenesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

node/src/BaseClient.ts Show resolved Hide resolved
@adarovadya adarovadya requested a review from a team as a code owner July 11, 2024 10:38
Ubuntu and others added 6 commits July 11, 2024 10:39
Signed-off-by: Adar Ovadia <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Adar Ovadia <[email protected]>
Signed-off-by: Adar Ovadia <[email protected]>
Signed-off-by: Adar Ovadia <[email protected]>
Signed-off-by: Adar Ovadia <[email protected]>
Signed-off-by: Adar Ovadia <[email protected]>
node/src/BaseClient.ts Show resolved Hide resolved
node/src/Transaction.ts Show resolved Hide resolved
@GumpacG
Copy link
Collaborator

GumpacG commented Aug 20, 2024

Closing as #2136 took its place.

@GumpacG GumpacG closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Node.js wrapper
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants