-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: Add BITFIELD
and BITFIELD_RO
commands
#1510
Merged
acarbonetto
merged 8 commits into
valkey-io:main
from
Bit-Quill:java/integ_guiang_bitfield_ro
Jun 4, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f3fd3ae
Java: Add `BITFIELD` and `BITFIELD_RO` command (#314)
GumpacG 4042998
Resolved conflicts
GumpacG 5738fe8
Addressed PR comments
GumpacG 71f67d8
Missed PR comment
GumpacG 789f674
Resolved conflicts
GumpacG fe8425a
Addressed PR comments
GumpacG ada74ea
Rebased
GumpacG 3733e22
Improved import
GumpacG File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -172,6 +172,8 @@ pub enum RequestType { | |||||
BLMove = 169, | ||||||
GetDel = 170, | ||||||
SRandMember = 171, | ||||||
BitField = 172, | ||||||
BitFieldReadOnly = 173, | ||||||
SInterCard = 175, | ||||||
} | ||||||
|
||||||
|
@@ -348,6 +350,8 @@ impl From<::protobuf::EnumOrUnknown<ProtobufRequestType>> for RequestType { | |||||
ProtobufRequestType::BLMove => RequestType::BLMove, | ||||||
ProtobufRequestType::GetDel => RequestType::GetDel, | ||||||
ProtobufRequestType::SRandMember => RequestType::SRandMember, | ||||||
ProtobufRequestType::BitField => RequestType::BitField, | ||||||
ProtobufRequestType::BitFieldReadOnly => RequestType::BitFieldReadOnly, | ||||||
ProtobufRequestType::SInterCard => RequestType::SInterCard, | ||||||
} | ||||||
} | ||||||
|
@@ -520,6 +524,8 @@ impl RequestType { | |||||
RequestType::BLMove => Some(cmd("BLMOVE")), | ||||||
RequestType::GetDel => Some(cmd("GETDEL")), | ||||||
RequestType::SRandMember => Some(cmd("SRANDMEMBER")), | ||||||
RequestType::BitField => Some(cmd("BITFIELD")), | ||||||
RequestType::BitFieldReadOnly => Some(cmd("BITFIELD_RO")), | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
RequestType::SInterCard => Some(cmd("SINTERCARD")), | ||||||
} | ||||||
} | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acarbonetto, why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command is:
bitfield_ro
We don't replace letters, for example:
XDel
. NotXDelete
orStreamDelete
.What's different about the
_ro
?