-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: add xrevrange
command
#1534
Merged
acarbonetto
merged 7 commits into
valkey-io:main
from
Bit-Quill:java/integ_acarbo_add_xrevrange_command
Jun 11, 2024
Merged
Java: add xrevrange
command
#1534
acarbonetto
merged 7 commits into
valkey-io:main
from
Bit-Quill:java/integ_acarbo_add_xrevrange_command
Jun 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzhang-BQ
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java
Outdated
Show resolved
Hide resolved
* Init commit for XREVRANGE Signed-off-by: Andrew Carbonetto <[email protected]> * Updates to xrevrange Signed-off-by: Andrew Carbonetto <[email protected]> * Add XREVRANGE to rust Signed-off-by: Andrew Carbonetto <[email protected]> * Revert set changes Signed-off-by: Andrew Carbonetto <[email protected]> * Java: Add XREVRANGE command Signed-off-by: Andrew Carbonetto <[email protected]> * Documentation updates for xrevrange Signed-off-by: Andrew Carbonetto <[email protected]> * Revert small change Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto
force-pushed
the
java/integ_acarbo_add_xrevrange_command
branch
from
June 11, 2024 01:51
aecb8a9
to
0d79cb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is red - spotless?
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Yury-Fridlyand
approved these changes
Jun 11, 2024
Elen-Ghulam
approved these changes
Jun 11, 2024
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
* Java: add `xrevrange` command (#341) * Init commit for XREVRANGE Signed-off-by: Andrew Carbonetto <[email protected]> * Updates to xrevrange Signed-off-by: Andrew Carbonetto <[email protected]> * Add XREVRANGE to rust Signed-off-by: Andrew Carbonetto <[email protected]> * Revert set changes Signed-off-by: Andrew Carbonetto <[email protected]> * Java: Add XREVRANGE command Signed-off-by: Andrew Carbonetto <[email protected]> * Documentation updates for xrevrange Signed-off-by: Andrew Carbonetto <[email protected]> * Revert small change Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]> * Change XRANGE XREVRANGE to use array of pairs Signed-off-by: Andrew Carbonetto <[email protected]> * Update XRANGE XREVRANGE java client to use pairings return Signed-off-by: Andrew Carbonetto <[email protected]> * Update XRANGE XREVRANGE it tests Signed-off-by: Andrew Carbonetto <[email protected]> * SPOTLESS Signed-off-by: Andrew Carbonetto <[email protected]> * Update return Signed-off-by: Andrew Carbonetto <[email protected]> * cargo fmt Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adds the XREVRANGE command for Java.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.