Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: add xrevrange command #1534

Merged

Conversation

acarbonetto
Copy link
Collaborator

Issue #, if available:

Description of changes:

Adds the XREVRANGE command for Java.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@acarbonetto acarbonetto requested a review from a team as a code owner June 6, 2024 04:26
@acarbonetto acarbonetto added the java issues and fixes related to the java client label Jun 6, 2024
@acarbonetto acarbonetto self-assigned this Jun 6, 2024
Copy link
Collaborator

@tjzhang-BQ tjzhang-BQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

* Init commit for XREVRANGE

Signed-off-by: Andrew Carbonetto <[email protected]>

* Updates to xrevrange

Signed-off-by: Andrew Carbonetto <[email protected]>

* Add XREVRANGE to rust

Signed-off-by: Andrew Carbonetto <[email protected]>

* Revert set changes

Signed-off-by: Andrew Carbonetto <[email protected]>

* Java: Add XREVRANGE command

Signed-off-by: Andrew Carbonetto <[email protected]>

* Documentation updates for xrevrange

Signed-off-by: Andrew Carbonetto <[email protected]>

* Revert small change

Signed-off-by: Andrew Carbonetto <[email protected]>

---------

Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto acarbonetto force-pushed the java/integ_acarbo_add_xrevrange_command branch from aecb8a9 to 0d79cb9 Compare June 11, 2024 01:51
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is red - spotless?

Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto acarbonetto merged commit 529a3a3 into valkey-io:main Jun 11, 2024
46 checks passed
@acarbonetto acarbonetto deleted the java/integ_acarbo_add_xrevrange_command branch June 11, 2024 18:41
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 24, 2024
* Java: add `xrevrange` command (#341)

* Init commit for XREVRANGE

Signed-off-by: Andrew Carbonetto <[email protected]>

* Updates to xrevrange

Signed-off-by: Andrew Carbonetto <[email protected]>

* Add XREVRANGE to rust

Signed-off-by: Andrew Carbonetto <[email protected]>

* Revert set changes

Signed-off-by: Andrew Carbonetto <[email protected]>

* Java: Add XREVRANGE command

Signed-off-by: Andrew Carbonetto <[email protected]>

* Documentation updates for xrevrange

Signed-off-by: Andrew Carbonetto <[email protected]>

* Revert small change

Signed-off-by: Andrew Carbonetto <[email protected]>

---------

Signed-off-by: Andrew Carbonetto <[email protected]>

* Change XRANGE XREVRANGE to use array of pairs

Signed-off-by: Andrew Carbonetto <[email protected]>

* Update XRANGE XREVRANGE java client to use pairings return

Signed-off-by: Andrew Carbonetto <[email protected]>

* Update XRANGE XREVRANGE it tests

Signed-off-by: Andrew Carbonetto <[email protected]>

* SPOTLESS

Signed-off-by: Andrew Carbonetto <[email protected]>

* Update return

Signed-off-by: Andrew Carbonetto <[email protected]>

* cargo fmt

Signed-off-by: Andrew Carbonetto <[email protected]>

---------

Signed-off-by: Andrew Carbonetto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java issues and fixes related to the java client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants